Fix ECC validation regression#10260
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Apr 24, 2026
Merged
Conversation
|
Contributor
Author
|
Jenkins retest this please |
Contributor
|
Retest this please Jenkins. The history is no longer available. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a regression in ECC point validation during X9.63 public key import by ensuring the legacy import wrapper treats inputs as untrusted, and adds a regression test to catch off-curve points in the future.
Changes:
- Update
wc_ecc_import_x963_exto passuntrusted=1so imported points are validated as on-curve. - Add an API test that imports a deliberately off-curve P-256 point and expects rejection.
- Register the new test in the ECC API test header.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wolfcrypt/src/ecc.c | Restores on-curve validation by treating X9.63 imports as untrusted in the wrapper. |
| tests/api/test_ecc.h | Declares and registers a new ECC X9.63 off-curve regression test. |
| tests/api/test_ecc.c | Adds a regression test asserting off-curve X9.63 points are rejected. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Jenkins retest this please |
Contributor
Author
|
Jenkins retest this please |
JacobBarthelmeh
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a regression accidentally added in #9851 due to rebasing after #10133 has landed. Added a test to catch this in the future.
Fixes zd#21654.